optimize: optimize healthcheck#5048
Open
ningmingxiao wants to merge 1 commit into
Open
Conversation
ningmingxiao
force-pushed
the
speed_up
branch
2 times, most recently
from
32becea to
4058db1
Compare
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
haytok
reviewed
Jul 7, 2026
Comment on lines
+552
to
+553
| hcStr, ok := label[labels.HealthCheck] | ||
| if !ok || hcStr == "" { |
Member
There was a problem hiding this comment.
This condition seems reversed:
Suggested change
| hcStr, ok := label[labels.HealthCheck] | |
| if !ok || hcStr == "" { | |
| if hcStr, ok := label[labels.HealthCheck]; ok && hcStr != "" { |
Comment on lines
-462
to
-466
| statusC, err := task.Wait(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
IMO, this seems unrelated to the optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduce about 100ms
ref:#5047